Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added interceptor to authenticate through api token #305

Merged
merged 19 commits into from
Oct 16, 2023
Merged

added interceptor to authenticate through api token #305

merged 19 commits into from
Oct 16, 2023

Conversation

daliclovr
Copy link
Contributor

@daliclovr daliclovr commented Sep 15, 2023 •
edited
Loading

  • Added grpc interceptor to handle auth through an api token.
  • Addd unittesting for the new interceptor
  • Added some logic from past review to UI
  • Added creation of APITokens to development environment so services works smoothely in that env.
  • Added a feature flag to do the deployment smoothly without downtimes.

@daliclovr daliclovr changed the title added interceptor to authenticate through api token Draft: added interceptor to authenticate through api token Sep 15, 2023
@daliclovr daliclovr changed the title Draft: added interceptor to authenticate through api token added interceptor to authenticate through api token Sep 15, 2023
@daliclovr daliclovr marked this pull request as draft September 15, 2023 14:04
@daliclovr daliclovr marked this pull request as ready for review September 15, 2023 15:12
Jossec101
Jossec101 requested changes Sep 16, 2023
View reviewed changes
src/Data/Repositories/APITokenRepository.cs Outdated Show resolved Hide resolved
test/NodeGuard.Tests/Rpc/AuthInterceptorTests.cs Outdated Show resolved Hide resolved
src/Rpc/AuthInterceptor.cs Outdated Show resolved Hide resolved
src/Rpc/AuthInterceptor.cs Outdated Show resolved Hide resolved
@Jossec101 Jossec101 mentioned this pull request Sep 18, 2023
Closed
Base automatically changed from api-auth-ui to main September 19, 2023 08:15
@daliclovr daliclovr requested a review from Jossec101 September 25, 2023 15:17
@daliclovr daliclovr changed the base branch from main to api-auth-ui September 25, 2023 15:18
@daliclovr daliclovr changed the base branch from api-auth-ui to main September 25, 2023 15:18
@daliclovr daliclovr force-pushed the api-auth-grpc-interceptor branch from 1ea46d2 to b52f42a Compare September 26, 2023 08:13
Jossec101
Jossec101 previously approved these changes Oct 3, 2023
View reviewed changes
test/NodeGuard.Tests/Rpc/GRPCAuthInterceptorTests.cs Outdated Show resolved Hide resolved
@daliclovr
Copy link
Contributor Author

Reviewed. Can someone please review this 🙏

@daliclovr
Copy link
Contributor Author

Tests which are failing are expected to fail since the feature flag is set to false

@Jossec101 Jossec101 merged commit e8138c4 into main Oct 16, 2023
1 check failed
@Jossec101 Jossec101 deleted the api-auth-grpc-interceptor branch October 16, 2023 16:18
@Jossec101 Jossec101 restored the api-auth-grpc-interceptor branch October 16, 2023 16:41
@Jossec101 Jossec101 deleted the api-auth-grpc-interceptor branch October 16, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jossec101 Jossec101 Jossec101 approved these changes

@RodriFS RodriFS RodriFS approved these changes

@markettes markettes Awaiting requested review from markettes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daliclovr @RodriFS @Jossec101